Merge the codelabs branch into main branch #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial setup * setup YAML parsing * format * load codelab files * move logic into CodelabUi class, start stubbing out code * Set up right panels * Add CodeMirror editor * Add CodelabState * fix HTML * Add step buttons * remove print * Load code and update when the step changes * Add run button and console panel * add flutter_codelab * Ignore /example/codelabs directory in analysis and builders * Add tabs to console panel * Get flutter compilation working * add TODO * exclude codelabs in dart_source_cleanup build step * remove whitespace
* Add GithubCodelabFetcher * make gh_ref and gh_path optional query parameters
* add codelabs.html to allowed files in main.py * Add show solution button
|
FYI the only unreviewed commit is 4a90fa3, which runs |
|
@kevmoo should I commit the But 3353d19 fails because it does analysis before building the project. What's the best-practice here? |
|
Should have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.